Add agent task conversation foundation#1323
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 103bdb60f1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 83041e0366
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06d4958075
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4d3a0c0ec9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
force-pushed
the
kennylopez-agent-tasks-foundation
branch
from
4d3a0c0 to
8ad906e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ad906e802
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7b625f1f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75a20b271b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return threadMessages.filter( | ||
| (entry) => !hiddenAgentConversationMessageIds.has(entry.message.id), | ||
| ); |
There was a problem hiding this comment.
Because this filtering happens only inside ChannelPane, the upstream useChannelUnreadState has already built threadUnreadCounts and its open-thread effect marks every unfiltered threadMessages entry read. In a source thread with a task marker and unread task replies, those replies are hidden here but still counted/cleared when the source thread is opened, so users can lose task unread state without seeing the messages. Push the hidden-id filtering into the unread/read-state inputs or exclude these ids there too.
Useful? React with 👍 / 👎.
| KIND_AGENT_CONVERSATION_COMPAT, // 40004 — staging-compatible focused agent conversation marker | ||
| KIND_STREAM_MESSAGE_DIFF, // 40008 — message diffs | ||
| KIND_AGENT_CONVERSATION, // 40010 — focused agent conversation marker |
There was a problem hiding this comment.
Adding these marker kinds to the desktop channel filters without updating mobile/lib/shared/relay/nostr_models.dart breaks the documented sync between the Flutter EventKind.channelEventKinds and desktop CHANNEL_EVENT_KINDS. In workspaces where marker events are published (desktop publishes the 40004 compat kind and the relay now supports 40010), mobile channel subscriptions will not receive that state even though desktop treats it as channel activity.
Useful? React with 👍 / 👎.
1 participant
Summary
Stack
Snapshots
Task marker and recap
Channel Tasks tab
Tests
git diff --check origin/main..HEADcd desktop && pnpm check:file-sizes && ./node_modules/.bin/tsc --noEmitcd desktop && pnpm testcargo test --manifest-path desktop/src-tauri/Cargo.toml deep_link --lib